Conversation
The property `mavenFilteringVersion` is referenced in usage.md.vm but was accidentally removed in 38534e3 (Cleanup deps), which inlined the version as a hardcoded string without noticing the site documentation dependency. This caused ${mavenFilteringVersion} to appear unresolved on the published usage page. Restore the property with a comment explaining it must not be removed, and change the dependency back to reference it via the property. Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The property
mavenFilteringVersionis referenced insrc/site/markdown/usage.md.vmbutwas removed from
pom.xmlin commit38534e3("Cleanup deps"), which inlined themaven-filtering version as a literal string. This caused
${mavenFilteringVersion}toappear unresolved on the published usage page at
https://maven.apache.org/plugins/maven-resources-plugin/usage.html.
Root Cause: Commit
38534e3replaced<version>${mavenFilteringVersion}</version>witha hardcoded
<version>3.5.1</version>and removed the<mavenFilteringVersion>property,not realising it was also consumed by the site documentation.
Fix: Restore
<mavenFilteringVersion>3.5.1</mavenFilteringVersion>in the<properties>block (with a comment explaining it must not be removed) and change the dependency back to
reference it via the property. Same approach as apache/maven-remote-resources-plugin#8.
Fixes #468
Generated with Hermes Agent
Co-authored-by: Claude Sonnet 4.6 noreply@anthropic.com