Conversation
maven-resources-plugin 4.x requires Maven 4, which defaults project.build.sourceEncoding to UTF-8 (MNG-7763). The explicit declaration in IT pom.xml files is therefore redundant and can be removed. Empty <properties> blocks are also removed. Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the redundant
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>property from all IT
pom.xmlfiles undersrc/it/.Rationale
Since MNG-7763, Maven 4 defaults
project.build.sourceEncodingtoUTF-8when notexplicitly set. Since
maven-resources-plugin4.x requires Maven 4, explicitlydeclaring this property in IT POMs is redundant noise. Empty
<properties>blocksleft after the removal are also cleaned up.
Files changed
src/it/MRESOURCES-110/pom.xml— encoding line removed (block keepsreplaceThisproperty)src/it/MRESOURCES-171/pom.xml— encoding line and empty<properties>block removedsrc/it/MRESOURCES-231/pom.xml— encoding line and empty<properties>block removedsrc/it/MRESOURCES-257/pom.xml— encoding line and empty<properties>block removedsrc/it/gh-312/pom.xml— encoding line removed (block keeps compiler source/target properties)src/it/include-git-ignore/pom.xml— encoding line and empty<properties>block removedNote:
src/it/MRESOURCES-231/src/main/resources/test.txtreferences${project.build.sourceEncoding}as a filter expression under test — it is intentionally leftunchanged, and will still resolve correctly since Maven 4 provides the default.
Co-authored-by: Claude Sonnet 4.6 noreply@anthropic.com