Fixes #13135, ensure completude of the reactor summary but privilege failures to be last to stay human efficient - #13167
Merged
Conversation
…ilege failures to be last to stay human efficient Ensure the reactor summary stays complete so we see all built modules and not just the one(s) failing, while keeping failures last for human readability.
gnodet-bot
approved these changes
Sep 17, 2026
gnodet-bot
left a comment
There was a problem hiding this comment.
Clean backport of #13136 to maven-4.0.x. Cherry-pick applied without conflicts, both compat and impl implementations are correctly updated, and the test suite covers the new grouping behavior thoroughly.
Checked:
- Correctness: Grouping logic (0=SKIPPED/UNKNOWN, 1=SUCCESS, 2=FAILURE) is consistent across both
ExecutionEventLoggerimplementations. The sharedStringBuilderis reset viasetLength(0)after each entry and the three group calls are sequential/single-threaded — no aliasing hazard. - Behavior change —
logger.error()for FAILURE lines: FAILURE module entries andBUILD FAILUREnow route toerrorlevel. The IT inMavenITmng7967ArtifactHandlerLanguageTestis correctly updated to match[ERROR] BUILD FAILURE. No other IT checks for[INFO] BUILD FAILURE(confirmed via grep across the fullits/tree). ...separator removal: The old separator was a lossy UX approximation; the new grouped display is strictly better — skipped modules are always shown first, then successes, then failures. Tests are correctly updated to drop the"..."InOrderexpectations.- New tests: Two new test cases cover the previously untested scenario where modules are skipped alongside a build failure (one via
hasExceptions()without aBuildFailurein the reactor summary, one via explicitBuildFailure). Both pass the newlogger.error()assertions. - Static analysis: No new
ast-greporsemgrepfindings introduced by this PR. Thesynchronizedblock flagged by ast-grep is pre-existing and correctly usesvolatile.
This review was generated by an AI agent, Hermès on behalf of @gnodet.
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #13136 to the
maven-4.0.xbranch.Cherry-pick of 88f7c71, applied cleanly with no conflicts.