Fixes #13135: address review on reactor summary (UNKNOWN group, local StringBuilder) [maven-4.0.x] - #13181
Merged
gnodet merged 1 commit intoSep 18, 2026
Conversation
… local StringBuilder) Port review findings from apache#13173 to maven-4.0.x: - Move StringBuilder out of ReactorSummaryRequest record and allocate locally in logReactorSummaryGroup, eliminating mutable state from the data-holder. - Assign group=2 to the UNKNOWN BuildSummary branch so any future BuildSummary subclass is logged at error level last, not silently grouped with SKIPPED modules.
gnodet-bot
approved these changes
Sep 18, 2026
gnodet-bot
left a comment
gnodet-bot
left a comment
There was a problem hiding this comment.
Both findings from the #13173 review cleanly ported to maven-4.0.x:
StringBuildermoved to local variable —ReactorSummaryRequestis now a pure immutable data-holder.logReactorSummaryGroupallocates its ownStringBuilderper call, eliminating the latent mutable-state risk.- UNKNOWN branch →
group = 2— any futureBuildSummarysubclass will surface at error level last rather than silently blending with SKIPPED modules.
Both compat/maven-embedder and impl/maven-cli are in sync. No gaps.
Metadata: category bug, suggested milestone 4.0.0-rc-7.
This review was generated by an AI agent, Hermès on behalf of @gnodet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward-port of review findings from #13173 to
maven-4.0.x.Applied to both
compat/maven-embedderandimpl/maven-cli:StringBuilderout of theReactorSummaryRequestrecord and allocate it locally insidelogReactorSummaryGroup. The record is a pure data-holder; carrying mutable state in it is a latent correctness trap.group = 2to theelsebranch so any futureBuildSummarysubclass is rendered last at error level rather than silently grouped with SKIPPED modules.