Conversation
gnodet
force-pushed
the
fix/mng-1088-re-enable-reactor-plugin-it
branch
from
September 21, 2026 08:54
d778d4c to
18b35f2
Compare
…r handles it correctly MNG-7977 (closed/fixed) introduced the concurrent builder which properly schedules reactor-internal plugins: the plugin project is built up to the 'ready' phase before the consuming project is planned. This commit re-enables MavenITmng1088ReactorPluginResolutionTest and reworks it to actually test the concurrent builder feature: - Use 'mvn package -b concurrent' (explicit concurrent builder, no fallback) - No pre-built plugin jar in a local repo — the plugin is compiled from source within the same reactor build - Update the plugin to use Maven 4 API (maven-plugin-api 4.1.0-SNAPSHOT) and POM model 4.1.0 - Remove the old 'repo/' directory (Maven 3 fallback, no longer needed) - Bind the touch goal to the 'package' phase (was 'initialize') Verified passing locally against maven-4.1.0-SNAPSHOT.
gnodet
force-pushed
the
fix/mng-1088-re-enable-reactor-plugin-it
branch
from
September 21, 2026 11:38
18b35f2 to
3878fba
Compare
gnodet
marked this pull request as ready for review
September 21, 2026 12:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-enable
MavenITmng1088ReactorPluginResolutionTest, which was disabled pending the concurrent builder work (MNG-7977).Background
MNG-1088 covers the case where a plugin is built and used within the same multiproject build. In Maven 3, this worked via a fallback: if the plugin's JAR hadn't been produced yet, Maven would resolve it from the repository. This fallback was fragile and could cause inconsistencies (MNG-7977).
How the Concurrent Builder Fixes This
Maven 4's
BuildPlanExecutorhandles this correctly incomputePlan():The
readyphase sits aftercompileandresources, so the plugin's classes are compiled and packaged before the consuming project is planned and executed — regardless of which lifecycle phase the user requested on the command line.Verification
IT passes against
4.0.0-SNAPSHOT:The test description is updated to reflect the Maven 4 semantics (proper scheduling via the concurrent build plan, rather than fallback to repository resolution).
Hermes Agent (Claude Sonnet 4.6) on behalf of Guillaume Nodet