[MNG-8667] Recognize injected parent profiles during validation - #13240
Merged
Merged
Conversation
gnodet-bot
approved these changes
Sep 22, 2026
gnodet-bot
left a comment
gnodet-bot
left a comment
There was a problem hiding this comment.
Clean backport of #13205 to maven-4.0.x.
Cherry-pick of 5cd1b60264 applied without conflicts. The fix is correct: getInjectedProfileIds() returns Map<String, List<String>> (source → profile IDs); chaining .values().stream().flatMap(Collection::stream) correctly flattens all injected profile identifiers into the validation set. The package-private visibility change on getAllProfiles is justified by the regression test in the same package. The test constructor call matches the 4.0.x DefaultMaven signature exactly. No adaptation concerns.
This review was generated by an AI agent, Hermès on behalf of @gnodet.
elharo
changed the title
Profile validation normally discovers parent profiles by walking MavenProject parent links. When construction of a parent MavenProject fails, its active profiles can still contribute to the effective model but are omitted from validation. Include the recorded injected profile IDs when validating requested profiles and add a focused regression test for the unavailable-parent path.
gnodet
force-pushed
the
backport/MNG-8667-to-4.0.x
branch
from
September 22, 2026 14:26
80a6b7d to
0fb353b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #13205 to
maven-4.0.x.Cherry-pick of 5cd1b60, applied cleanly with no conflicts.