Added CCC and close notify capabilities - #49
Conversation
| IoBuffer buf = (IoBuffer) message; | ||
|
|
||
| try { | ||
| if (sslHandler.isOutboundDone() && !sslHandler.isCCCEnabled()) { |
There was a problem hiding this comment.
This entire 'if' block was originally commented out in our fork, citing issues with CCC and close notify. To not break backwards compatibility, I added the addition check for CCC enabled.
|
Hi! I'll review the proposed change soon. Thanks! |
|
Thanks for the commit. I'll review it soon. |
|
This PR looks good to me but I did not see test cases for the altered behavior in:
|
|
Hi @maartenbosteels, do you feel like merging the PR, even with the missing test cases? |
|
Hi @elecharny , how are you? Yes, I think it's safe. |
|
Hi @maartenbosteels ! going very well :-) I hope you also do well ! Yes, please, go ahead with the PR and merge it! |
Added clear command channel (CCC) and close notify support, based off of our forked revisions that we use with our ftpserver fork.