feat(services/goosefs): bump goosefs-sdk to 0.2.1 and expose cache features - #8269
Merged
Xuanwo merged 2 commits intoSep 11, 2026
Merged
Conversation
…atures 0.2.1 compiles metadata and page caches only when opted in, so OpenDAL can keep the default GooseFS client as a gRPC data plane.
Contributor
Author
|
CI Error Link:#8271 |
Xuanwo
requested changes
Sep 10, 2026
| services-ghac = ["dep:opendal-service-ghac"] | ||
| services-github = ["dep:opendal-service-github"] | ||
| services-goosefs = ["dep:opendal-service-goosefs"] | ||
| services-goosefs-metadata-cache = [ |
Member
There was a problem hiding this comment.
This should not be exposed at opendal side.
Keep metadata-cache, page-cache, and page-cache-io-uring on opendal-service-goosefs. Applications that use the facade enable them by depending on that crate directly so Cargo unifies the features.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
goosefs-sdk0.2.1 compiles the client metadata cache and the disk-backed pagecache only behind Cargo features, so the default client stays a gRPC data plane.
OpenDAL currently depends on 0.1.9, which does not expose those features and
cannot compile the 0.2.1 cache backends.
Forwarding the opt-in features lets applications enable the caches without
pulling
lru, foyer, or io_uring into everyservices-goosefsbuild.What changes are included in this PR?
Bump
goosefs-sdkfrom 0.1.9 to 0.2.1 withdefault-features = false.Add opt-in features on
opendal-service-goosefsand theopendalfacade:services-goosefs-metadata-cachemetadata-cacheservices-goosefs-page-cachepage-cacheservices-goosefs-page-cache-io-uringpage-cache-io-uringDocument how to enable the features and the runtime knobs
(
GOOSEFS_METADATA_CACHE_ENABLED,GOOSEFS_USER_CLIENT_CACHE_ENABLED).Drop the 0.1.9 note that
$GOOSEFS_CONF_DIRwas ignored; 0.2.1 reads it.Are there any user-facing changes?
Yes.
services-goosefsnow tracksgoosefs-sdk0.2.1. The default GooseFS buildno longer enables the SDK's old
metrics-pushgatewaydefault.configuration: metadata cache is on by default once compiled; page cache
stays off until
GOOSEFS_USER_CLIENT_CACHE_ENABLED=true(and cache dirs)are set.
page-cache-io-uringalready enablespage-cache. io_uring is Linux-only;other targets still build the portable
tokio::fsstore.Example: