HDDS-16465. Validate snapshot chains before mutation - #11253
Merged
Merged
Conversation
Validate global and path chains before adding or deleting snapshots to prevent partial updates when validation fails. Reject inconsistent deletion membership and add regression coverage for failed operations. Tests: TestSnapshotChain (20 passed), checkstyle, git diff --check.
Contributor
Author
Contributor
|
Thanks @andyhuangdev for the patch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
SnapshotChainManager updates the global snapshot chain before updating the per-path chain. If path validation fails, the global chain remains changed while the path chain does not.
For example, adding a snapshot with a valid global predecessor but a missing path predecessor throws an exception after inserting the snapshot into the global chain. Similarly, deleting a snapshot with a mismatched path removes its global entry while leaving its path entry intact.
This change validates both chains before modifying either, under the existing synchronized methods. Deletion checks membership and neighbors in both chains and rejects inconsistent membership before removing the snapshot.
What is the link to the Apache JIRA
HDDS-16465
How was this patch tested?
Added regression tests covering failed insertion into empty and nonempty chains, and deletion with a mismatched path.
All 20 tests in TestSnapshotChain passed. Checkstyle and git diff --check passed.