Conversation
* HDDS-14496-zdu: HDDS-16399. Fix flaky testFinalizationEmptyClusterDataDistribution (apache#11228) HDDS-15966. Fix flaky TestScmHAFinalization#testSnapshotFinalization (apache#11200)
errose28
added
the
zdu
dombizita
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Proactively apply a few test-only timing fixes for upgrade related tests to prevent them from becoming flaky:
TestScmDataDistributionFinalizationtransferLeadershipdoes not block the client until the election finishes, sogetActiveSCMcould return null the way the test is currently written. Wait for the election to finish instead.OMUpgradeTestUtilsWhat is the link to the Apache JIRA
HDDS-16500
How was this patch tested?
These are proactive fixes based on observations so there is no failing run to compare these with. Tests continue to pass on my fork with this change (the acceptance test failure is unrelated).