Skip to content

HDDS-16523. Fix flaky openFileTable assertions in TestHSync #11281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chungen0126 merged 2 commits into from
Sep 21, 2026
Merged

HDDS-16523. Fix flaky openFileTable assertions in TestHSync #11281

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef4ee92
HDDS-16523. Intermittent failure in TestHSync#testHSyncOpenKeyCommitA…
rjgoyln Sep 20, 2026
8542bb6
Explain why the second table read waits for the double buffer flush
rjgoyln Sep 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestHSync.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,6 +492,8 @@ public void testHSyncOpenKeyCommitAfterExpiry() throws Exception {
// Create key2 without hsync
try (FSDataOutputStream os1 = fs.create(key2, true)) {
os1.write(1);
// Wait for double buffer flush to avoid flakiness because RDB iterator bypasses table cache
cluster.getOzoneManager().awaitDoubleBufferFlush();
// There should be 2 key in openFileTable
assertThat(getOpenKeyInfo(BUCKET_LAYOUT))
.extracting(OmKeyInfo::getKeyName)
Expand Down Expand Up @@ -586,6 +588,8 @@ public void testHSyncOpenKeyDeletionWhileDeleteDirectory() throws Exception {
try (FSDataOutputStream os = fs.create(key1, true)) {
os.write(1);
os.hsync();
// Wait for double buffer flush to avoid flakiness because RDB iterator bypasses table cache
cluster.getOzoneManager().awaitDoubleBufferFlush();
// There should be 1 key in openFileTable
assertThat(getOpenKeyInfo(BUCKET_LAYOUT))
.extracting(OmKeyInfo::getKeyName)
Expand Down
Loading