HDDS-14018. Avoid repeated operations in SCMNodeManager#getNodeStatistics - #11292
Open
sarvekshayr wants to merge 3 commits into
Open
sarvekshayr wants to merge 3 commits into
sarvekshayr wants to merge 3 commits into
Conversation
…tics HDDS-14018. Avoid repeated operations in SCMNodeManager#getNodeStatistics Usie etAllNodes() in the remaining call sites
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Improvements done for
SCMNodeManager#getNodeStatistics:getAllNodes()calls, store and reuse the listnodeStateStatistics(by eachget...NodeCount()method)nodeUsageStatisticsmay base its calculations on values aggregated bynodeSpaceStatisticsinstead of iterating storage reports itselfWhat is the link to the Apache JIRA
HDDS-14018
How was this patch tested?
All the tests in
TestSCMNodeManagerpassed.