fix: reject aggregation on sequence fields#409
Open
QuakeWang wants to merge 1 commit into
Open
Conversation
Signed-off-by: QuakeWang <wangfuzheng0814@foxmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: #257
Rust aggregation schema validation allowed
fields.<sequence-field>.aggregate-function, but the runtime ignores that option because sequence fields are forced tolast_value. Java rejects this metadata during schema validation, so Rust could create table options that are not accepted by Java validation.Brief change log
sequence.fieldcolumns during aggregation schema validation.last_valuefor existing or external metadata.Tests
cargo fmt --all -- --checkcargo clippy --all-targets --workspace --features fulltext,vortex,mosaic -- -D warningscargo test -p paimon --lib aggregationcargo test -p paimon --lib schemacargo test -p paimon-datafusion --test pk_tables aggregationAPI and Format
No storage format change. This tightens validation for invalid aggregation table options.
Documentation
Updated SQL docs for sequence-field aggregation behavior.