[python] Run native commit tests only in the Rust Plan CI job - #10139
Open
jackylee-ch wants to merge 1 commit into
Open
jackylee-ch wants to merge 1 commit into
jackylee-ch wants to merge 1 commit into
Conversation
The native commit tests were gated only by @requires_native (the pypaimon_rust module being importable), so the standard test job ran them against the PyPI pypaimon-rust wheel. That wheel predates the v14 commit bridge, so native commit preparation raises, is caught, and the commit falls back to Python, tripping the "must not fall back" assertion on Python 3.10-3.13 (3.6 and 3.7 have no wheel and skip). Mark these tests native_plan, as was done for native reads (apache#10067), so they are excluded from the wheel-based test job and run only in the Rust Plan job against the from-source paimon-rust runtime, where the commit bridge matches.
jackylee-ch
force-pushed
the
python-native-commit-rust-lane
branch
from
September 23, 2026 09:50
b3b394f to
4d58954
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The native commit tests are gated only by
@requires_native(whetherpypaimon_rustis importable), so theTestsjob runs them against the PyPIpypaimon-rustwheel. That wheel predates the v14 commit bridge, so nativecommit preparation raises, is caught, and the commit falls back to Python —
tripping the "must not fall back" assertion on Python 3.10-3.13. (3.6/3.7 have
no wheel and skip; the Rust Plan job builds paimon-rust from source and passes.)
Mark these tests
native_plan, as done for native reads (#10067), so they areexcluded from the wheel-based
Testsjob and run only in the Rust Plan job,against the from-source runtime where the commit bridge matches.
Tests
pytest --collect-only -m 'not native_plan'now deselects the 37 native tests(67 -> 30 collected); the mock/Python-path tests and the
native=Falsecasesstill run in the
Testsjob, and the Rust Plan job still exercises the nativeones.