add comments to pop/ack/changInvisibleTime, No Code change

[winglechen]

约1200行注释，无代码修改

[RockteMQ-AI]

Review by github-manager-bot (Incremental)

Summary

5 new commits since the previous review, adding Javadoc and inline comments to SendMessageProcessor, HookUtils, TimerMessageStore, and BrokerConfig. All changes are documentation-only — no functional code modifications.

Findings

• [Positive] HookUtils.java — The class-level Javadoc clearly documents the 4-step processing pipeline (checkBeforePutMessage → checkInnerBatch → handleScheduleMessage → handleLmqQuota) and the abort-on-non-null contract. This is very helpful for understanding the send-message pre-processing flow.

• [Positive] HookUtils.handleScheduleMessage — The inline comments clarifying the timer vs delay-level routing logic are accurate. The note "normal message or committed message can be delayed" correctly describes the tranType guard.

• [Positive] HookUtils.transformTimerMessage — The "calculate deliver time" comment and the expanded explanation of the isRolledTimerMessage double-check path improve readability of this non-trivial method.

• [Positive] TimerMessageStore.isReject — The 3-tier flow control Javadoc (≤1x admit, 1x-2x probabilistic, ≥2x reject) is clear and matches the implementation. The note "always return false with default config" is a useful operational hint.

• [Info] SendMessageProcessor.java:117 — The comment // no batch message after 5.0 on the isBatch() branch is helpful context. Consider also noting whether this branch can be safely deprecated/removed in a future major version cleanup.

• [Info] HookUtils.java:167 — Changed "Delay Delivery" to "Delay Delivery, useless with default config". This is accurate when timerWheelEnable=true (default), but when the timer wheel is disabled, delay-level delivery is still the primary scheduling mechanism. Consider rephrasing to "Delay Delivery (bypassed when timer wheel is enabled)" for precision.

Verdict

All new comments are accurate and improve code readability. No issues found. LGTM.

---

Automated review by github-manager-bot