Conversation
snoopdave
commented
Sep 14, 2026
snoopdave
left a comment
Contributor
Author
There was a problem hiding this comment.
PR-Review: 1 inline blocking comment posted.
| || uri.endsWith("/bootstrap-token!redeem.rol")); | ||
| boolean installer = uri != null && (tokenPage || uri.contains("/roller-ui/install/") | ||
| || uri.endsWith("/roller-ui/register.rol") | ||
| || uri.endsWith("/roller-ui/register!save.rol") |
Contributor
Author
There was a problem hiding this comment.
🐞Codex Issue: Blocking: The gate only matches /register.rol and /register!save.rol, but Struts dynamic method invocation also exposes URLs such as /register!execute.rol and /register!activate.rol. Those direct routes can reach the initial registration flow without the token. Gate the resolved register action/method (or reject all register methods while bootstrap is incomplete) and add regression coverage for every allowed method.
Contributor
Author
|
PR-Review: General Issues The following issue needs action but is not tied to one changed line:
|
Contributor
Author
|
Need to test this on the 5.2 -> 6.1.6 upgrade, that is the last actual DB schema change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
mvn -pl app -DskipTests compileBootstrapSecurityTestandInstallTestgit diff --checkNew log messages
Here's what the new seucurity code looks like in
roller.log:New security code page
And here's the new securoty code page:
Release consideration
If we do an RC4, we should consider including this PR in that release candidate.