-
Notifications
You must be signed in to change notification settings - Fork 72
Add ML-DSA (FIPS 204) post-quantum signature support #651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ffang
wants to merge
10
commits into
apache:main
Choose a base branch
from
ffang:PQC-SIGNATURE
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
042d5f7
Add ML-DSA (FIPS 204) post-quantum signature support
ffang 43b5317
Parameterize the negative signature tests across all ML-DSA parameter…
Arpan0995 7401714
Merge pull request #2 from Arpan0995/pqc-signature-negative-tests
ffang 58ef7d8
Emit dsig11:DEREncodedKeyValue for keys without a structured KeyValue…
Arpan0995 036194d
Merge pull request #4 from Arpan0995/pqc-signature-keyvalue-fix
ffang 5898249
Resolve dsig11:DEREncodedKeyValue on the StAX inbound path
Arpan0995 dcd65cd
Reject malformed DEREncodedKeyValue content cleanly
Arpan0995 2859acc
Reject malformed DEREncodedKeyValue content cleanly on the DOM path
Arpan0995 d47f99c
Merge pull request #7 from Arpan0995/pqc-signature-inbound-derkeyvalue
ffang 0189ba1
Use finalized ML-DSA URIs and reject unsupported SignatureContext
ffang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something to think about as a (perhaps subsequent) improvement - we could store all the algorithm
Strings in a staticMap(then you could just do aMap.containsKey()) and reduce the number of classes by passing in arguments (stored with each map entry). Most of these subclasses are the same except for algorithm names. There are a few special cases though for algs that take parameters but I think the code could be structured differently for those to create them by the caller and only if needed.