[MINOR] OOC Fix Blocking Threads#2489
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2489 +/- ##
============================================
- Coverage 71.41% 71.40% -0.01%
+ Complexity 48817 48815 -2
============================================
Files 1572 1572
Lines 189089 189090 +1
Branches 37101 37101
============================================
- Hits 135030 135014 -16
- Misses 43596 43612 +16
- Partials 10463 10464 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
|
||
| protected CompletableFuture<Void> submitOOCTask(Runnable r, StreamContext ctx) { | ||
| ExecutorService pool = CommonThreadPool.get(); | ||
| ExecutorService pool = CommonThreadPool.getDynamicPool(); |
There was a problem hiding this comment.
This should not make a difference, The CommonThreadPool.get() should be the right way to get our shared threadpool that does get killed with the Java process.
There was a problem hiding this comment.
This should make a difference because submitOOCTask may be used for blocking work (e.g. dequeue()). If we now use a fixed sized thread pool (which especially causes problems in environments with fewer enabled CPUs thus smaller number of workers on the default thread pool), this may block scheduled tasks from making progress that are needed for those workers to unblock.
There was a problem hiding this comment.
okay did not know you had more tasks than threads in the pool.
Blocking threads now use a dynamic thread pool.