Skip to content

[SYSTEMDS-3891] Add GeneralMMultOOCPrimitive - #2595

Open
janniklinde wants to merge 1 commit into
apache:mainfrom
janniklinde:ooc/mmult
Open

[SYSTEMDS-3891] Add GeneralMMultOOCPrimitive#2595
janniklinde wants to merge 1 commit into
apache:mainfrom
janniklinde:ooc/mmult

Conversation

@janniklinde

Copy link
Copy Markdown
Contributor

This patch adds a new general matrix multiply OOC primitive. This primitive requests materialization of both inputs and traverses input tiles in a row/col major way. This primitive is a baseline approach and aims to limit the number of intermediate output tiles.

Assisted-by: AI

@codecov

codecov Bot commented Aug 20, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 65.00000% with 112 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.40%. Comparing base (83b789a) to head (7f8d3d4).

Files with missing lines Patch % Lines
...ntime/ooc/primitives/GeneralMMultOOCPrimitive.java 64.08% 78 Missing and 24 partials ⚠️
...va/org/apache/sysds/runtime/ooc/util/OOCUtils.java 20.00% 4 Missing and 4 partials ⚠️
.../runtime/instructions/ooc/MMultOOCInstruction.java 94.44% 0 Missing and 1 partial ⚠️
.../org/apache/sysds/runtime/ooc/cache/OOCFuture.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2595      +/-   ##
============================================
- Coverage     71.42%   71.40%   -0.02%     
- Complexity    50517    50564      +47     
============================================
  Files          1631     1632       +1     
  Lines        195928   196229     +301     
  Branches      38178    38199      +21     
============================================
+ Hits         139947   140124     +177     
- Misses        44996    45089      +93     
- Partials      10985    11016      +31     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

1 participant