chore(frontend): remove the unused scroll-to-step request stream - #8613
Open
aglinxinyuan wants to merge 1 commit into
Open
aglinxinyuan wants to merge 1 commit into
aglinxinyuan wants to merge 1 commit into
Conversation
Contributor
Automated Reviewer SuggestionsBased on the
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8613 +/- ##
============================================
- Coverage 92.78% 92.77% -0.01%
Complexity 4902 4902
============================================
Files 1236 1236
Lines 52165 52155 -10
Branches 6411 6409 -2
============================================
- Hits 48402 48389 -13
- Misses 2191 2196 +5
+ Partials 1572 1570 -2
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Removes
AgentService's scroll-to-step request stream, which can never fire. Pure deletion, no behaviour change: −74 lines.The chain exists end to end but has no trigger:
requestScrollToStep()is the only producer and nothing calls it, soscrollToStepSubjectnever emits, theagent-chatsubscriber never runs, and the privatescrollToStep()it dispatches to is unreachable.History
agent-servicethat manages LLM agents", which shipped the whole chain at onceagent.service.tshas calledrequestScrollToStepat any point in the history, and no UI control invokes itAny related issues, documentation, discussions?
Closes #8610
How was this PR tested?
Existing tests only — this PR removes code and the tests that covered it.
From
frontend/:npx ng test --watch=false --include='**/agent.service.spec.ts' --include='**/agent-chat.component.spec.ts' --include='**/agent-panel.component.spec.ts'— 193 tests pass across the three files.yarn --cwd frontend format:ci— clean.Verification, re-runnable by a reviewer:
Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 5)
🤖 Generated with Claude Code