THRIFT-6316: Fetch the test and tutorial JavaScript libraries over HTTPS - #3899
Merged
Merged
Conversation
Client: js,test Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
mergeable
Bot
added
javascript
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ant
download_jslibstarget inlib/js/test, the two test result pages and the JavaScripttutorial fetch jQuery, QUnit and DataTables over plain HTTP. All of those hosts serve the same
bytes over HTTPS -- fetched both ways and compared checksums -- and
cdn.datatables.netanswersHTTP with a 301 to HTTPS anyway.
Verified:
ant download_jslibsinlib/js/testis BUILD SUCCESSFUL after the change and writesjquery.js (95957 bytes), qunit.js (151757) and qunit.css (7875) -- the same sizes the HTTP URLs
return.
lib/ts/test/build.xmlis deliberately left out: #3747 already moves its four QUnit URLs toHTTPS, and its remaining jQuery line is best folded into that PR rather than conflicting with it.
The W3C validator badge links in nine other test pages are also left alone; they are links and
images, not code the pages execute.
🤖 Generated with Claude Code