Skip to content

fix(cpp): align the ANTLR4 compatibility bound with the enforced range #965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ColinLeeo merged 1 commit into from
Sep 17, 2026
+3 −3
Merged

fix(cpp): align the ANTLR4 compatibility bound with the enforced range #965

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cpp/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ dependencies are resolved:

ANTLR4, Snappy, LZ4, lzokay, SIMDe, zlib, Zstandard, and liblzma are currently
resolved through this policy. A compatible system ANTLR4 must be version 4.9.3
or newer and earlier than 5.0.0, and provide an `antlr4_static` or
or newer and earlier than 4.13.0, and provide an `antlr4_static` or
`antlr4_shared` target. A compatible system Snappy must be version 1.2.1 or
newer in the 1.x release series and provide the `Snappy::snappy` CMake target.
A compatible system LZ4 must be version 1.9.4 or newer in the 1.x release
Expand Down
2 changes: 1 addition & 1 deletion cpp/cmake/tests/ANTLR4DependencyTest.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ endfunction()

_tsfile_write_fake_antlr4("${_TSFILE_COMPATIBLE_ROOT}" 4.9.3 antlr4_static)
_tsfile_write_fake_antlr4("${_TSFILE_TOO_OLD_ROOT}" 4.9.2 antlr4_static)
_tsfile_write_fake_antlr4("${_TSFILE_INCOMPATIBLE_ROOT}" 5.0.0 antlr4_shared)
_tsfile_write_fake_antlr4("${_TSFILE_INCOMPATIBLE_ROOT}" 4.13.0 antlr4_shared)
file(MAKE_DIRECTORY "${_TSFILE_MISSING_ROOT}")

_tsfile_run_antlr4_case(system-compatible SYSTEM SYSTEM TRUE
Expand Down
2 changes: 1 addition & 1 deletion cpp/third_party/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ dependency before compiling and linking TsFile.
`Vocabulary.cpp`, `ATN.cpp`, `LL1Analyzer.cpp`, `LL1Analyzer.h`,
`LexerATNSimulator.cpp`, `LexerATNSimulator.h`, `IntervalSet.cpp`, `Any.h`,
and `CPPUtils.cpp`. utf8cpp is not modified.
- Resolution: `SYSTEM` accepts ANTLR4 4.9.3 or newer and earlier than 5.0.0
- Resolution: `SYSTEM` accepts ANTLR4 4.9.3 or newer and earlier than 4.13.0
through an `antlr4_static` or `antlr4_shared` target; `BUNDLED` downloads or
reuses both verified archives; and `AUTO` prefers a compatible system
package before falling back to the verified archives.
Expand Down
Loading