Conversation
Propagate metadata and device-index read errors through table queries and tag filters instead of returning empty or partial results or misleading errors. Preserve terminal result-set failures and reject unexpected short reads while allowing EOF-limited prefetches. Use checked schema lookups in the C/Python bindings and release tag filters when query creation fails. Add fault-injection regression coverage for row and batch queries, tag filtering, and leaf/internal device indexes. Validation: C++ 953 passed, 3 skipped; Python 356 passed, 1 skipped. Spotless, Black, and whitespace checks passed.
ColinLeeo
commented
Sep 24, 2026
Comment on lines
51
to
198
| @@ -177,22 +192,25 @@ std::shared_ptr<ResultSetMetadata> TableResultSet::get_metadata() { | |||
| int TableResultSet::get_next_tsblock(common::TsBlock*& block) { | |||
| int ret = common::E_OK; | |||
| block = nullptr; | |||
| if (read_error_ != common::E_OK) { | |||
| return read_error_; | |||
| } | |||
|
|
|||
Contributor
Author
There was a problem hiding this comment.
There are quite a few state transitions here, so I'd prefer to refactor this logic. For example, I'd introduce an explicit state machine and model the read-state transitions separately for row-wise and batch reads.
Remove the legacy no-error table schema and tag factory entry points. Make table and timeseries schema lookups return allocated objects with ERRNO output parameters, including read failures instead of silently returning empty or partial schemas. Update the C++ reader, CLI, examples, Python bindings, Go cgo bridge, and tests to the unified API. Add fault-injection coverage for all-timeseries schema reads. Validation: C++ 953 passed, 3 skipped; Python 357 passed, 1 skipped; Go tests passed. Formatting and whitespace checks passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Propagate metadata and device-index read errors through table queries and tag filters instead of returning empty or partial results or misleading errors. Preserve terminal result-set failures and reject unexpected short reads while allowing EOF-limited prefetches.
Use checked schema lookups in the C/Python bindings and release tag filters when query creation fails. Add fault-injection regression coverage for row and batch queries, tag filtering, and leaf/internal device indexes.
Validation: C++ 953 passed, 3 skipped; Python 356 passed, 1 skipped. Spotless, Black, and whitespace checks passed.