[https://github.com/apache/wicket/issues/1492] make partial page upda…#1493
Open
reiern70 wants to merge 1 commit into
Open
[https://github.com/apache/wicket/issues/1492] make partial page upda…#1493reiern70 wants to merge 1 commit into
reiern70 wants to merge 1 commit into
Conversation
martin-g
reviewed
Jun 22, 2026
| super(page); | ||
|
|
||
| update = new XmlPartialPageUpdate(page) | ||
| update = newPartialPageUpdate(page); |
Member
There was a problem hiding this comment.
It will be better to add another constructor public AjaxRequestHandler(final Page page, final PartialPageUpdate ppu)
Contributor
Author
There was a problem hiding this comment.
Fine by me... checking
Contributor
There was a problem hiding this comment.
Factory method is better because constructor argument does not allow access to protected methods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make partial page update creation pluggable.