[ZEPPELIN-6372] Reimplement custom TSLint rules as ESLint rules#5279
Open
voidmatcha wants to merge 1 commit into
Open
[ZEPPELIN-6372] Reimplement custom TSLint rules as ESLint rules#5279voidmatcha wants to merge 1 commit into
voidmatcha wants to merge 1 commit into
Conversation
Signed-off-by: YONGJAE LEE <dev.yongjaelee@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
PR #5109 removed all TSLint code from zeppelin-web-angular. This restores the two custom lint rules on the ESLint flat config as a local plugin at
zeppelin-web-angular/eslint-rules:@Optional()parameters last.public-api.tsbarrels must be alphabetically ordered by module specifier.Both are registered in
eslint.config.jsand enforced by the existing husky/lint-staged pre-commit hook that runseslint --fixon staged.tsfiles. Logic and autofix are ported from the original TSLint rules onto the typescript-eslint AST. The rules are plain CommonJS, matching eslint.config.js.eslint src projectsreports no violations on the current tree, so no existing code changes are required.What type of PR is it?
Improvement
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-6372
How should this be tested?
cd zeppelin-web-angular && npm run lintpasses.public-api.ts, then runeslint --fixand confirm the rule flags and reorders it.Questions: