refactor(jsonld): remove the unreachable getSupportedTypes guard - #8518
Open
Maxcastel wants to merge 1 commit into
Open
refactor(jsonld): remove the unreachable getSupportedTypes guard#8518Maxcastel wants to merge 1 commit into
Maxcastel wants to merge 1 commit into
Conversation
Maxcastel
force-pushed
the
refactor/remove-unreachable-defensive-branches
branch
from
September 9, 2026 12:36
1ac8b4d to
3cdab3b
Compare
Maxcastel
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes one guard whose false branch cannot be reached, and the
ignoreErrorsphpstan entry that was hiding it.