feat(test): keep ApiTestCase BrowserKit assertions verbose for Symfony 8.2 - #8523
Open
ousamabenyounes wants to merge 1 commit into
Open
feat(test): keep ApiTestCase BrowserKit assertions verbose for Symfony 8.2#8523ousamabenyounes wants to merge 1 commit into
ousamabenyounes wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symfony >= 8.2 flips BrowserKit response assertions to non-verbose by default, hiding the response body on failure. ApiTestCase now re-enables verbose assertions in a #[Before] hook so failing API tests keep showing the (JSON) body; projects can still opt out via setBrowserKitAssertionsAsVerbose(false) in setUp() or per-assertion verbose: false.
Test verification (RED → GREEN)
With the fix reverted, the new test fails (RED):
With the fix applied, the test passes (GREEN):
Full local suite
Command:
docker run --rm -v "$PWD":/app -w /app php:8.4-cli bash -c 'php vendor/bin/phpunit --ignore-baseline && php vendor/bin/php-cs-fixer fix --dry-run --diff'Fix #8450