test: drop the symfony/property-info 6.4 compatibility guards - #8524
Open
Maxcastel wants to merge 1 commit into
Open
test: drop the symfony/property-info 6.4 compatibility guards#8524Maxcastel wants to merge 1 commit into
Maxcastel wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thirteen tests guarded their body behind a
method_exists()check onPropertyInfoExtractor::getType(), with a comment claiming property-info 6.4 was still supported:symfony/property-infois constrained to^7.4 || ^8.0in the root and in the components that require it, andgetType()is present and undeprecated on both bounds:https://github.com/symfony/property-info/blob/7.4/PropertyInfoExtractor.php
https://github.com/symfony/property-info/blob/8.1/PropertyInfoExtractor.php
So the guard always evaluates to true and none of those could run.