feat: release v0.2.6 - #58
Closed
janiussyafiq wants to merge 1 commit into
Closed
Conversation
Relax the lua-resty-session pin from an exact 4.1.5-1 to >= 4.1.5 so downstream rockspecs can upgrade lua-resty-session without luarocks uninstalling the newer version during dependency resolution.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: Comment |
Author
|
Superseded by #39, which will carry the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
lua-resty-saml0.2.5 pinslua-resty-session = 4.1.5-1exactly. When a downstream rockspec (api7/api7-ee-3-gateway#2181) upgrades tolua-resty-session = 4.2.0-1, luarocks installs 4.2.0 first and then uninstalls it while resolving this exact pin, downgrading the runtime back to 4.1.5. This silently disables features that live in the newer lua-resty-session and fails EE CI.What
lua-resty-session >= 4.1.5in the main rockspec and in a new0.2.6-0rockspec.feat: release v0.2.6for the release workflow).Note: v0.2.6 also ships the fixes merged since v0.2.5 (#32, #41, #42, #43, #50).