fix(openapi): Preserve RequestWithoutId and its required fields when bundling - #2774
Open
vdusek wants to merge 1 commit into
Open
fix(openapi): Preserve RequestWithoutId and its required fields when bundling#2774vdusek wants to merge 1 commit into
vdusek wants to merge 1 commit into
Conversation
vdusek
added
adhoc
Contributor
|
✅ Preview for this PR (commit |
This comment was marked as outdated.
This comment was marked as outdated.
vdusek
force-pushed
the
fix/request-without-id-bundling
branch
from
August 21, 2026 17:37
3a96e7d to
767ee67
Compare
vdusek
changed the title
vdusek
marked this pull request as ready for review
August 21, 2026 18:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RequestWithoutIdwas a bare$refwith sibling keys, so the bundler inlined it: the publishedopenapi.jsonhas no such component, the add-request / batch-add-requests / update-request bodies point straight atRequestBase, andrequired: [uniqueKey, url]disappears. Generated clients therefore get no schema for those bodies —apify-client-pythonfell back to a response shape and sentuserDataand friends snake_cased, which the API rejects with HTTP 400 (apify/apify-client-python#1026).Wrapping
RequestWithoutIdin a single-memberallOfkeeps it a named component through bundling.required: [uniqueKey, url]moves toRequestBase, andRequestdrops the now-redundant entries — net constraints unchanged.redocly lintpasses, and the bundle keeps the component with all 11 properties and the required constraint.✍️ Drafted by Claude Code