Skip to content

test: cover PPE charging on the Scrapy integration end-to-end - #1096

Open
vdusek wants to merge 3 commits into
masterfrom
test/scrapy-ppe-charging-e2e
Open

test: cover PPE charging on the Scrapy integration end-to-end#1096
vdusek wants to merge 3 commits into
masterfrom
test/scrapy-ppe-charging-e2e

Conversation

@vdusek

@vdusek vdusek commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Adds an e2e test that runs a pay-per-event Scrapy Actor on the platform and asserts that pushed items are charged and that max_total_charge_usd is enforced. The spider scrapes three products; at $0.05 an item a $0.125 budget covers two, so the third push must be dropped and never charged.

No source changes — the behavior was already correct. This locks it in so a future Scrapy or Twisted upgrade that does change the reactor's scheduling context fails loudly instead of silently costing developers revenue.

✍️ Drafted by Claude Code

@vdusek vdusek added adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. labels Aug 21, 2026
@vdusek vdusek self-assigned this Aug 21, 2026
@github-actions github-actions Bot added this to the 147th sprint - Tooling team milestone Aug 21, 2026
@github-actions github-actions Bot added the tested Temporary label used only programatically for some analytics. label Aug 21, 2026
@codecov

codecov Bot commented Aug 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.37%. Comparing base (fcc767a) to head (f6a6794).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1096      +/-   ##
==========================================
+ Coverage   92.31%   92.37%   +0.06%     
==========================================
  Files          51       51              
  Lines        3317     3317              
==========================================
+ Hits         3062     3064       +2     
+ Misses        255      253       -2     
Flag Coverage Δ
e2e 34.73% <ø> (ø)
integration 56.55% <ø> (ø)
unit 87.00% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vdusek
vdusek marked this pull request as ready for review August 21, 2026 12:27
@vdusek
vdusek requested a review from Pijukatel August 21, 2026 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants