test: cover PPE charging on the Scrapy integration end-to-end - #1096
Open
vdusek wants to merge 3 commits into
Open
test: cover PPE charging on the Scrapy integration end-to-end#1096vdusek wants to merge 3 commits into
vdusek wants to merge 3 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1096 +/- ##
==========================================
+ Coverage 92.31% 92.37% +0.06%
==========================================
Files 51 51
Lines 3317 3317
==========================================
+ Hits 3062 3064 +2
+ Misses 255 253 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
vdusek
marked this pull request as ready for review
August 21, 2026 12:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an e2e test that runs a pay-per-event Scrapy Actor on the platform and asserts that pushed items are charged and that
max_total_charge_usdis enforced. The spider scrapes three products; at $0.05 an item a $0.125 budget covers two, so the third push must be dropped and never charged.No source changes — the behavior was already correct. This locks it in so a future Scrapy or Twisted upgrade that does change the reactor's scheduling context fails loudly instead of silently costing developers revenue.
✍️ Drafted by Claude Code