Conversation
🦋 Changeset detectedLatest commit: 80ede73 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
generatenow decodes formatter output beforeURLSearchParams.set, so the query string encodes once. The decodedtrisar-9-16, matching ImageKit's documented form.ImageKit
arvalues such as9-16were written asar-9%252D16intr. After one query decode ImageKit seesar-9%2D16, which is not a valid aspect ratio.extractkeeps hyphens that appear inside values, so official URLs liketr:ar-4-3,w-400round-trip asar: "4-3"instead ofar: "4", andtransform()of a generatedar-9-16URL no longer truncates the ratio.Fixes #195.
Decision
Decode in ImageKit
generate, and re-encode extra hyphens only in ImageKitextract. Alternative: change the shared operations parser to keep everything after the first key/value separator. That shared change made Uploadcare parsequality/lighter/as"lighter/"(trailing/is their key/value separator). Can switch if you would rather fix the parser once for every provider.Test plan
deno test src/providers/imagekit.test.ts%252D; extract ofar-9-16/ar-4-3; transform keepsar-9-16)deno check src/deno test src/(85 tests)?tr=w-640,ar-9-16against a real ImageKit image and confirm the crop is 9:16