Fix link ordering so libm/pthread resolve in make all#304
Open
stumpylog wants to merge 1 commit into
Open
Conversation
Keep link-time libraries out of CFLAGS so they land AFTER the object/archive inputs on each link line. GNU ld with --as-needed (the Debian/Ubuntu default) drops a library placed before the inputs that reference it, leaving libm (sqrt/pow/ceil) and pthread_* (from the threadsafe libsqlite3) undefined. See asg017#84 and asg017#93. Scope the libraries per target: the loadable extension is just sqlite-vec.c, which references libm but no raw pthread/dl symbols (SQLite is resolved by the host at load time), so it links libm only via LOADABLE_LIBS. dl and pthread stay in LINK_LIBS for the targets that embed the threadsafe SQLite amalgamation (cli, static-into-exe, test-unit). This also fixes Android/Bionic cross-builds, which run on a Linux host (CONFIG_LINUX) but have no standalone libpthread.
stumpylog
force-pushed
the
fix/lib-linking
branch
from
0f8ffda to
3c98042
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Linux,
make allfails at link time:-lmlives inCFLAGS, which is expanded before the archive inputs on each link line. GNUld --as-needed(Debian/Ubuntu default) then drops libm before it reachessqlite-vec.a. Same trap forlibpthread(sqlite is built threadsafe but-lpthreadis never linked).Fixes #84, #93, #2.
Fix
Move link libraries out of
CFLAGSinto a dedicatedLINK_LIBSappended after the inputs on every link line.Verification
Complementary to #290/#292, which add
$(CFLAGS)to compile lines but don't touch the-lmlink ordering.