fix: order temporal migration operations under the toposort - #839
Merged
zachdaniel merged 2 commits intoAug 24, 2026
Conversation
matt-beanland
force-pushed
the
temporal-ordering
branch
from
August 24, 2026 08:17
9c852a1 to
6b0c280
Compare
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor checklist
Stacked on #838.
Problem: AddPrimaryKey and AddTemporalForeignKey declared no dependencies, so the toposort that replaced pairwise after?/2 ordering in #798 generated migration ALTER TABLE tier ADD PRIMARY KEY before CREATE TABLE tier.
Fix: declare each operation's actual prerequisites as requires facts, so the generator can't emit a forward reference.
Migration regeneration is subject of next PR in the stack.
@zachdaniel green locally, also credo and format ok. Second of ash_postgres stack likely 4 PR's, stacks on #838