Upload coverage from the jax and dask CI jobs - #985
Merged
Conversation
Coverage was uploaded from the numpy-only coverage job, so code that only runs under a non-numpy array namespace (the CCDData wrapper classes, spec-only fallbacks such as the nanmedian fallback) was reported as uncovered and codecov/patch failed on every array-API PR. Add the existing ``cov`` tox factor to the jax job and the dask escape-baseline job and upload from those too, tagged with per-backend codecov flags (numpy, jax, dask). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RQMJZUaaxfqGDk41GLSaFK
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #985 +/- ##
==========================================
+ Coverage 96.01% 96.13% +0.12%
==========================================
Files 8 8
Lines 1655 1655
==========================================
+ Hits 1589 1591 +2
+ Misses 66 64 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coverage is currently uploaded only from
ubuntu-py312-coverage, which runs with numpy. Code that executes only under a non-numpy array namespace — theCCDDatawrapper classes in_ccddata_wrapper_for_array_api.py, spec-only fallbacks like the one in #978 — is therefore never seen by codecov, andcodecov/patchfails on every array-API PR (#975, #978, #980 are red only for this reason).This adds the existing
covtox factor to the jax job (py313-jax-cov) and the dask escape-baseline job (py312-alldeps-dask-enforce-cov) and uploads from those as well. Uploads are tagged with codecov flags (numpy,jax,dask) so the per-backend reports can be told apart; codecov merges them per commit.Verified locally:
tox -e py313-jax-covruns the full suite (377 passed, 40 skipped, 9 xfailed) and writescoverage.xmlwith_ccddata_wrapper_for_array_api.pyat 85% line coverage — that file is ~0% on the numpy job.Intended to merge before #975 / #978 / #980 so they can be rebased onto it.
🤖 Generated with Claude Code
https://claude.ai/code/session_01RQMJZUaaxfqGDk41GLSaFK