test: reduce repeated Windows pregate fixture setup - #8572
Merged
Merged
Conversation
atomantic
force-pushed
the
claim/issue-8463
branch
from
September 26, 2026 01:26
5424a03 to
5e467f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The pregate hidden-content tests now build their committed Git fixture once and copy it for each isolated case. This removes repeated source copies and Git commits from Windows setup while preserving the real Git, CLI, index, and destructive-fixture assertions. Each copy refreshes its index metadata before the test snapshots it.
Earlier fixes already on
mainbatch the Brain pagination seed (#8496), reuse the primary-checkout Git sandbox (#6003), and give the first detached process test its bounded Windows startup deadline (#8496). This PR finishes the remaining repeated pregate fixture setup in #8463. A full Windows CI run also exposed thatdeadExports.test.jsassumedorigin/mainexists in a shallow workflow-dispatch checkout. The test now uses the prior commit as its comparison base when that ref is absent, while pull-request CI continues to use its exactCI_BASE_SHA.Validation
npm run pregateon the final branch diff: 30 files, 405 tests passed.5424a0363: run 36207675569 and run 36208055736. All three Windows server shards and both CI gates succeeded in each run.Closes #8463