Skip to content

Remove unused React Testing Library development dependency #165

Description

@atomantic

Problem

The client workspace declares @testing-library/react, but the repository has no import or use of its render, query, event, or type APIs.

Evidence

client/package.json:26 declares @testing-library/react as ^16.3.2; the exact lockfile resolves @testing-library/react@16.3.2. A repository-wide source, test, script, and configuration search found zero references outside that manifest declaration (zero imported symbols and zero call sites across zero files). npm ls --package-lock-only --all @testing-library/react shows it only under @fsf/client, with no kept package retaining it transitively. Existing client tests use Vitest directly rather than Testing Library.

Impact

Removing an unused test helper trims the development dependency graph and its transitive packages without reducing currently exercised test behavior.

Implementation plan

Remove @testing-library/react from client/devDependencies, regenerate the root lockfile using npm install --package-lock-only --ignore-scripts, and verify no test configuration begins relying on it. No replacement API is needed.

Acceptance criteria

@testing-library/react is absent from the client manifest and root lockfile; repository searches still find no Testing Library imports; the current unit, integration, and client build workflows pass.

Verification

Run npm install --package-lock-only --ignore-scripts, npm ls @testing-library/react, npm run build, and npm run test:unit.

Dependencies and related work

Independent of #120 and #149#155. If future component tests adopt Testing Library, add it back in the same change that introduces its first import.

Scope

Replacement complexity: Trivial. Likely files: client/package.json, package-lock.json. Non-goals: converting existing tests, changing Vitest, or introducing a different browser-test framework.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    depsDependency audit findingplanClaimable backlog itemseverity:lowLow severity

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions