Fix condition, resource, and ECS Fargate validation - #241
Closed
satyakigh wants to merge 5 commits into
Closed
Conversation
An empty condition body reached an arm that quoted the body's first key, panicking on a body that has no keys. It now falls to the shape arm and is reported like any other body that is not a condition function. The Fargate task-size rules also read a declared size differently in each engine. Both now share one notion of a written scalar through the coercion module, match the CPU-unit spelling exactly (Fargate offers a fixed set of Cpu values, so a padded '0512' names none of them), and read Memory as the number it denotes. A value written in any other shape names no size, so the pair is left to the schema type rules instead of being reported as an unoffered size. A PlacementConstraints that resolves to AWS::NoValue is removed before the task is created, so the task does not pin placement; it is no longer reported.
satyakigh
changed the title
…fault(). - Prevented Fargate GB-to-MiB overflow panics with checked arithmetic. - Aligned CEL/Rego handling of placement constraints and conditional AWS::NoValue. - Report required Fargate properties removed by AWS::NoValue. - Allowed valid SAM Connectors and IgnoreGlobals. - Moved resource/condition shape validation after Fn::ForEach expansion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change improves shared template validation and aligns ECS Fargate behavior across the CEL and Rego engines.