chore(deps): npm: bump undici from 7.28.0 to 7.29.0 - #708
Conversation
Bumps [undici](https://github.com/nodejs/undici) from 7.28.0 to 7.29.0. - [Release notes](https://github.com/nodejs/undici/releases) - [Commits](nodejs/undici@v7.28.0...v7.29.0) --- updated-dependencies: - dependency-name: undici dependency-version: 7.29.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
scottschreckengaust
left a comment
There was a problem hiding this comment.
Principal Architect Review — PR #708 (chore(deps): npm: bump undici 7.28.0 → 7.29.0)
1. Verdict
Approve. Correct, minimal, automated transitive-dependency security bump that strictly reduces the repo's vulnerability surface. Zero blocking issues. The one red CI check is not attributable to this diff (see Tests & CI).
2. Vision alignment
Advances the tenet of a reliable, bounded control plane: undici 7.29.0 patches four advisories — GHSA-4cwx-7wf7-3272 (High, CVSS 7.4, cross-user info disclosure via malformed private Cache-Control directives), GHSA-jr45-8vmc-qm54 (shared-cache bypass), GHSA-m8rv-5g2x-5cg5 (CRLF injection in content-type), and GHSA-v3r7-h72x-cjcm (cookie-attribute injection). Keeping HTTP-client dependencies patched directly serves control-plane security. No tenet is traded; no ADR required.
3. Blocking issues
None.
4. Non-blocking suggestions / nits
- Second copy of vulnerable undici still present —
integrations/jira-forge-app/package-lock.jsonstill pinsundici@7.28.0and carries the identical four GHSAs (confirmed in the failing osv-scanner output). This is out of scope for this yarn.lock-only PR and is already covered by thenpmecosystemdirectories: ["**/*"]block in.github/dependabot.yml(open-PR limit 1, so it is queued behind this one). No action needed here; just ensure the sibling Dependabot PR is merged promptly to clear the advisory. - Governance (informational, waived) — Per ADR-003 the gate is an approved backing issue. This is an automated Dependabot security bump with no backing issue and a bot branch name (
dependabot/npm_and_yarn/undici-7.29.0); consistent with prior merged deps PRs (e.g. #624, #625), this is a de-facto waiver for automated maintenance, not a blocker.
5. Documentation
No docs required — no behavior, contract, env var, command, or public-API change. A transitive lockfile bump has no user-facing surface. Starlight mirror unaffected. No drift.
6. Tests & CI
No tests required or possible for a lockfile version bump; the dependency's own test suite covers the fix.
CI status: build (agentcore) pass, Validate PR title pass, Dead-code detection pass, CodeQL/auto-approve skipped. Secrets, deps, and workflow scan is RED — but the failure is pre-existing and NOT caused by this PR. The osv-scanner run reports 11 findings across sibling lockfiles: fast-uri 3.1.4 and ip-address 10.2.0 (yarn.lock), cryptography 49.0.0 (agent/uv.lock), and the forge-app undici 7.28.0 copy (nit #1). This PR removes undici from the yarn.lock findings — it is a strict net improvement. Blocking a security patch on unrelated queued Dependabot items would be counterproductive; recommend landing the sibling bumps (fast-uri, ip-address, cryptography, forge-app undici) to return the branch to green. No CDK construct/stack change → bootstrap synth-coverage not applicable.
7. Review agents run
The diff is a 3-line change to a single generated lockfile (yarn.lock) — no hand-authored source, types, control flow, comments, or tests. I hand-verified the only reviewable dimension: version, integrity (sha512), and resolved URL are mutually consistent and undici@^7.19.0 (transitive via cheerio) is satisfied by 7.29.0; corroborated the security rationale against the release notes and the osv-scanner CI output. Agents omitted, each because the diff genuinely does not touch its scope:
code-reviewer— omitted: no hand-authored source/style surface (generated lockfile only).silent-failure-hunter— omitted: no error-handling or fallback code.type-design-analyzer— omitted: no new/changed types.comment-analyzer— omitted: no comments in the diff.pr-test-analyzer— omitted: no test files and none warranted for a version bump./security-review— omitted as a code review: no IAM/Cedar/network/secrets/input-gateway code touched. The security dimension here is the dependency advisory itself, which I assessed directly above.
8. Human heuristics
- Proportionality — Pass. Single-line-triple lockfile edit; no abstraction or scope creep.
- Coherence — Pass. Belongs in root
yarn.lock; matches the established Dependabot flow and commit convention. - Clarity — Pass. Commit message and PR body state the CVEs and rationale precisely.
- Appropriateness — Pass. Automated, reversible, maintainable; the fix is validated by undici's own regression tests referenced in the release notes.
|
Looks like undici is up-to-date now, so this is no longer needed. |
Bumps undici from 7.28.0 to 7.29.0.
Release notes
Sourced from undici's releases.
Commits
9e38fc1Bumped v7.29.0 (#5590)d887e34fix: validate coerced header values for CRLF (#5579)33928bcfix: validate blob body content type98011a8fix(cache): harden cache directive parsing4a9dafbtest(retry): correct broken content-range fixtures in retry-handler.js1b5a531fix(retry): reject partial content length mismatch466e99dtest: cover crash on mixed unqualified and qualified private cache directives9f10f1efix: handle empty qualified private cache directive3bf91ddfix: harden cookie domain, path, and unparsed attribute validationDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.