feat: support updated operation IDs in replay#504
Conversation
zhongkechen
force-pushed
the
codex/updated-operation-ids-plugin-hooks
branch
2 times, most recently
from
da2e7c7 to
a8acb74
Compare
| if not was_updated: | ||
| self.state.emit_operation_replay_hook(next_checkpoint.operation) |
There was a problem hiding this comment.
if on_operation_start and on_operation_end is emitted on every invocation, how does that affect the Otel plugin's spans?
There was a problem hiding this comment.
replay is true so existed is true. The spans on replay will be created with links to the spans in the previous invocation.
There was a problem hiding this comment.
I guess I'm asking whether all spans from previous replays will be recreated for each invocation or if they will only be present for invocations where they are relevant
There was a problem hiding this comment.
Only in invocations they are relevant
| with self._updated_operation_hooks_lock: | ||
| if operation.operation_id in self._updated_operation_hooks: | ||
| return True | ||
| self._updated_operation_hooks.add(operation.operation_id) |
There was a problem hiding this comment.
why do we need to update this _updated_operation_hooks?
There was a problem hiding this comment.
Yeah, deduplication logic here is redundant. Removed.
zhongkechen
force-pushed
the
codex/updated-operation-ids-plugin-hooks
branch
4 times, most recently
from
dadb4e3 to
a972088
Compare
zhongkechen
force-pushed
the
codex/updated-operation-ids-plugin-hooks
branch
from
a972088 to
37add3f
Compare
zhongkechen
changed the title
3 participants
Summary:
Validation: