fix(core): detect bundled SDK via version stamp - #717
Open
nvasiu wants to merge 1 commit into
Open
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| return module_file.startswith("/var/lang/") | ||
| def _is_bundled(version: str = __version__) -> bool: | ||
| """True if the managed runtime stamped a +bundled label onto this install.""" | ||
| return "+bundled" in version |
Contributor
There was a problem hiding this comment.
Codex AI review · Finding arf_v1_m4vdthbymtstfubzqehpcuftc7
[P3] Match the bundled label exactly
This substring check also accepts valid, distinct local versions such as 2.0.0+bundleddebug, causing customer builds to be reported as managed-runtime -bundled installs. Compare against the exact +bundled suffix and add a negative test for a label beginning with bundled.
Suggested change
| return "+bundled" in version | |
| return version.endswith("+bundled") |
Contributor
Codex AI reviewFound one low-severity issue at Reviewed commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
The managed runtime now stamps a
+bundledlocal version label onto the installed durable SDK. This update reads the stamp to determine if the SDK is installed in the managed runtime (replacing the old method of checking the installation folder, which was unreliable).By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.