Skip to content

fix(proxy): Harden URI parsing in port forwarding proxy #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skazantsev merged 1 commit into from
Jul 8, 2026
Merged

fix(proxy): Harden URI parsing in port forwarding proxy #272

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 19 additions & 5 deletions patches/web-server/proxy-uri.diff
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ Index: code-editor-src/src/vs/server/node/proxyServer.ts
===================================================================
--- /dev/null
+++ code-editor-src/src/vs/server/node/proxyServer.ts
@@ -0,0 +1,186 @@
@@ -0,0 +1,200 @@
+import proxyServer from "http-proxy";
+import * as http from "http";
+import * as net from "net";
Expand Down Expand Up @@ -139,20 +139,34 @@ Index: code-editor-src/src/vs/server/node/proxyServer.ts
+ if (!targetPathname) {
+ return;
+ }
+ const [_, proxyPrefix, port] = targetPathname.split("/", 3);
+ const [_, proxyPrefix, portRaw] = targetPathname.split("/", 3);
+ if (!ACCEPTED_PROXY_PREFIXES.includes(proxyPrefix)) {
+ return;
+ }
+
+ if (!portRaw || !/^[1-9]\d*$/.test(portRaw)) {
+ return;
+ }
+ const port = Number(portRaw);
+
+ let base: string | undefined;
+ if (proxyPrefix === "ports") {
+ base = `/ports/${port}`;
+ base = `/ports/${portRaw}`;
+ targetPathname = targetPathname.slice(base.length);
+ }
+
+ // Collapse leading slashes/backslashes to prevent protocol-relative URL interpretation
+ targetPathname = targetPathname.replace(/^[/\\][/\\]+/, "/");
+
+ const target = new URL((targetPathname || "/") + (sourceUrl.search ?? ""), `http://0.0.0.0:${port}`);
+ if (target.hostname !== "0.0.0.0" || target.port !== String(port)) {
+ return;
+ }
+
+ return {
+ base,
+ port,
+ target: url.resolve(`http://0.0.0.0:${port}/`, targetPathname + (sourceUrl.search ?? "")),
+ port: String(port),
+ target: target.toString(),
+ };
+ }
+
Expand Down