Skip to content

fix(proxy): Reject out-of-range port numbers in proxy request#273

Merged
skazantsev merged 1 commit into
1.2from
fix/proxy-port-range-check
Jul 8, 2026
Merged

fix(proxy): Reject out-of-range port numbers in proxy request#273
skazantsev merged 1 commit into
1.2from
fix/proxy-port-range-check

Conversation

@skazantsev

@skazantsev skazantsev commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Description of Changes

Add port range validation (> 65535) before constructing the URL in
createProxyRequest. Without this, new URL() throws a TypeError for
invalid ports, causing an unhandled promise rejection and leaving the
client request hanging with no response.

Testing

  • Patch applies cleanly via prepare-src.sh
  • Confirmed the issue: curl /ports/99999/test triggers unhandled TypeError
  • After fix: out-of-range ports are rejected before URL construction

Additional Notes

Follow-up to #269.

Backporting

Same fix applied to main, 1.1, and 1.0.


By submitting this pull request, I confirm that you can use, modify, copy,
and redistribute this contribution, under the terms of your choice.

@skazantsev skazantsev requested a review from a team as a code owner July 8, 2026 15:29
sachinh-amazon
sachinh-amazon previously approved these changes Jul 8, 2026
@skazantsev skazantsev force-pushed the fix/proxy-port-range-check branch from 67e5968 to 2edf434 Compare July 8, 2026 15:45
@skazantsev skazantsev added this pull request to the merge queue Jul 8, 2026
Merged via the queue into 1.2 with commit 9105eb6 Jul 8, 2026
1 check passed
@skazantsev skazantsev deleted the fix/proxy-port-range-check branch July 8, 2026 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants