fix(proxy): Reject out-of-range port numbers in proxy request#275
Merged
Conversation
sachinh-amazon
previously approved these changes
Jul 8, 2026
skazantsev
force-pushed
the
fix/proxy-port-range-check-1.0
branch
from
5249c53 to
efc655e
Compare
skazantsev
force-pushed
the
fix/proxy-port-range-check-1.0
branch
from
efc655e to
be66d14
Compare
sachinh-amazon
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Add port range validation (> 65535) before constructing the URL in
createProxyRequest. Without this,new URL()throws aTypeErrorforinvalid ports, causing an unhandled promise rejection and leaving the
client request hanging with no response.
Testing
prepare-src.shAdditional Notes
Follow-up to #271.
Backporting
Same fix applied to all active branches.
By submitting this pull request, I confirm that you can use, modify, copy,
and redistribute this contribution, under the terms of your choice.