Extract connection activation into a shared hook - #2261
Merged
Merged
Conversation
Pure refactor: the activate-and-reset logic ConnectionRow inlined moves to its own hook so other callers can reuse it without duplicating the no-op-when-already-active check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ConnectionRowinto auseActivateConnectionhook, with its own tests. No behavior change.The connect route in Add connection links via a dedicated #/connect route activates a matching connection the same way the connections list does. Sharing one hook keeps the two from drifting, and splitting it out keeps the refactor from hiding inside a feature diff.
Validation
Clicking a connection in the connections list should still activate it and reset the graph view, exactly as before.
Related Issues
Prep for Add connection links via a dedicated #/connect route.
Check List
pnpm checkspasses with no errors.pnpm testpasses with no failures.