fix(review): prevent submission footer overlap - #1513
Open
leoreisdias wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The GitHub/GitLab review submission dialog kept its sticky action footer inside the scrollable form body. At constrained heights, the footer overlaid the final form control and visibly clipped the "View on GitHub after submitting" checkbox.
Fix
Move the action footer outside the scrollable body and make it a non-shrinking sibling. The form content can now scroll independently while the actions remain available without covering any fields.
Add a regression test that verifies the action footer is not contained by the dialog's scrollable form region.
Review Focus
The meaningful layout change is limited to the boundary between the scrollable form body and the persistent action footer. Submission behavior, button states, and platform actions are unchanged.
Before:

After:

Test Plan
DOM_TESTS=1 bun test packages/review-editor/components/ReviewSubmissionDialog.ui.test.tsx(6 pass)bun run --cwd apps/review buildtscis not on the root PATH after the latest upstream dependency layout; a direct app typecheck also reports unrelated baseline errors across existing files