Skip to content

fix(review): prevent submission footer overlap - #1513

Open
leoreisdias wants to merge 1 commit into
backnotprop:mainfrom
leoreisdias:feat/fix-review-submission-dialog-overlap
Open

fix(review): prevent submission footer overlap#1513
leoreisdias wants to merge 1 commit into
backnotprop:mainfrom
leoreisdias:feat/fix-review-submission-dialog-overlap

Conversation

@leoreisdias

@leoreisdias leoreisdias commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Problem

The GitHub/GitLab review submission dialog kept its sticky action footer inside the scrollable form body. At constrained heights, the footer overlaid the final form control and visibly clipped the "View on GitHub after submitting" checkbox.

Fix

Move the action footer outside the scrollable body and make it a non-shrinking sibling. The form content can now scroll independently while the actions remain available without covering any fields.

Add a regression test that verifies the action footer is not contained by the dialog's scrollable form region.

Review Focus

The meaningful layout change is limited to the boundary between the scrollable form body and the persistent action footer. Submission behavior, button states, and platform actions are unchanged.

Before:
file-c63dbd71d55ca53c3f9a43ceb8171eb8

After:
image

Test Plan

  • DOM_TESTS=1 bun test packages/review-editor/components/ReviewSubmissionDialog.ui.test.tsx (6 pass)
  • bun run --cwd apps/review build
  • Rebuilt the local hook bundle and verified the GitHub approval dialog against a live PR: the checkbox is fully visible above the footer and the two regions do not overlap
  • Impeccable layout detector reports no findings for the changed files
  • Full repository typecheck is currently unavailable from the root script because tsc is not on the root PATH after the latest upstream dependency layout; a direct app typecheck also reports unrelated baseline errors across existing files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant