test(mcp): reject narrowing optional additions - #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked Issue
Upstream issue: Gentleman-Programming#717 (
status:approved).This is a fork-first corrective PR and intentionally does not close the upstream issue.
🏷️ PR Type
type:bug— Bug fixtype:feature— New featuretype:docs— Documentation onlytype:refactor— Code refactoring (no behavior change)type:chore— Maintenance, dependencies, toolingtype:breaking-change— Breaking change📝 Summary
R3-001.📂 Changes
internal/mcp/tool_contract_test.go🧪 Test Plan
permissive additionalProperties optional addition error = <nil>.go test ./internal/mcp -count=1passes.🤖 Automated Checks
Fork-first note: the upstream issue is approved, but the fork-local governance job may not resolve an upstream issue through
context.repo. The final upstream PR will use the canonical issue-closing reference.✅ Contributor Checklist
Co-Authored-Bytrailer is present.💬 Notes for Reviewers
This exceptional fourth fork PR is a bounded post-stack correction required by native high-risk RDD. The finding is semantic: naming and typing a previously arbitrary key narrows accepted inputs even when the new property is optional.