chore(deps): update module github.com/docker/cli to v29.8.0+incompatible - #174
Merged
Merged
Conversation
docker/cli ships no go.mod, so this module supplies its dependency versions itself: v29.8.0 calls sortorder.NaturalCompare (added in sortorder v1.2.0) and sets container.HostConfig.Umask (added in moby/moby/api v1.56.0), both of which docker/cli v29.8.0's own vendor.mod pins. Regenerating the flag table picks up the new "docker run --umask" flag. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #173, whose
dockerflagsjob fails to build docker/cli v29.8.0.docker/cli ships a
vendor.modrather than ago.mod, socmd/dockerflagsgensupplies docker/cli's dependency versions itself and a docker/cli bump alone leaves them behind. v29.8.0 needs two of them raised to what its ownvendor.modpins:github.com/fvbommel/sortorderv1.1.0 → v1.2.0, forsortorder.NaturalCompare(undefined: sortorder.NaturalCompareincli/context/storeandcli-plugins/manager).github.com/moby/moby/apiv1.55.0 → v1.56.0, forcontainer.HostConfig.Umask(unknown field Umask in struct literal).Regenerating the flag table then picks up docker/cli v29.8.0's new
docker run --umaskflag, added todockerargs.RunFlagsand towantRunFlagsin the table's golden test. It takes a value, so no rule that indexesrunArgschanges behavior.Verified with
make dockerflags(clean regeneration),git diff --exit-code dockerargs/runflags.goafter committing the regenerated table,make dockerflags-test, andmake test.make coveragestays at 95.3%.🤖 Generated with Claude Code
Generated by Claude Code