Skip to content

ci: run every workflow step under bash -euo pipefail #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nozaq merged 1 commit into from
Sep 10, 2026
Merged

ci: run every workflow step under bash -euo pipefail #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,12 @@ env:
# renovate: datasource=npm depName=@devcontainers/cli
DEVCONTAINER_CLI_VERSION: "0.89.0"

# The runner's default shell adds only -e, so an unset variable or a failure
# mid-pipeline would otherwise pass silently.
defaults:
run:
shell: bash -euo pipefail {0}

jobs:
discover:
name: Discover features
Expand All @@ -33,7 +39,6 @@ jobs:
- name: List features under src/
id: discover
run: |
set -euo pipefail
features="$(find src -mindepth 2 -maxdepth 2 -name devcontainer-feature.json -printf '%h\n' \
| xargs -r -n1 basename \
| sort \
Expand Down Expand Up @@ -77,8 +82,6 @@ jobs:
env:
WORKSPACE: ${{ runner.temp }}/smoke
run: |
set -euo pipefail

if [ ! -f "src/${FEATURE}/smoke_test.sh" ]; then
echo "::error::src/${FEATURE}/smoke_test.sh is missing; every feature must ship one."
exit 1
Expand Down
8 changes: 6 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,12 @@ concurrency:
group: ${{ github.workflow }}-${{ github.event_name == 'workflow_dispatch' && 'release' || github.ref }}
cancel-in-progress: ${{ github.event_name == 'pull_request' }}

# The runner's default shell adds only -e, so an unset variable or a failure
# mid-pipeline would otherwise pass silently.
defaults:
run:
shell: bash -euo pipefail {0}

jobs:
release:
name: Publish features
Expand Down Expand Up @@ -49,8 +55,6 @@ jobs:
env:
GITHUB_TOKEN: ${{ steps.app-token.outputs.token }}
run: |
set -euo pipefail

changed=$(git status --porcelain -- 'src/*/README.md' | awk '{print $2}')
if [ -z "$changed" ]; then
echo "No documentation changes."
Expand Down
10 changes: 6 additions & 4 deletions .github/workflows/update-material.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,12 @@ concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: ${{ github.event_name == 'pull_request' }}

# The runner's default shell adds only -e, so an unset variable or a failure
# mid-pipeline would otherwise pass silently.
defaults:
run:
shell: bash -euo pipefail {0}

jobs:
update:
name: Refresh trusted material
Expand All @@ -30,8 +36,6 @@ jobs:
- name: Refresh trusted material
id: update
run: |
set -euo pipefail

changed="$(bash scripts/update-material.sh)"
echo "changed=${changed}" >> "${GITHUB_OUTPUT}"

Expand All @@ -48,8 +52,6 @@ jobs:
env:
GH_TOKEN: ${{ steps.app-token.outputs.token }}
run: |
set -euo pipefail

OWNER="${GITHUB_REPOSITORY_OWNER}"
REPO="${GITHUB_REPOSITORY#*/}"
BRANCH="housekeeper/update-material"
Expand Down
Loading