fix(demos): pin @coinbase/onchainkit to the locked 0.38.x instead of "latest" - #131
Open
memosr wants to merge 1 commit into
Open
fix(demos): pin @coinbase/onchainkit to the locked 0.38.x instead of "latest"#131memosr wants to merge 1 commit into
memosr wants to merge 1 commit into
Conversation
…"latest" Four workshop demos declare `"@coinbase/onchainkit": "latest"` while their committed `package-lock.json` is locked to a 0.38.x build. `latest` on npm is 1.1.2, a major version ahead, so a fresh `npm install` in any of them resolves the floating tag and pulls OnchainKit 1.x into a demo written and locked against the 0.38 API. Pin each manifest to a caret range matching the version already in its own lockfile, so the two agree and installs stay reproducible: | Demo | lockfile | pinned to | | --------------------- | -------- | ---------- | | mini-neynar | 0.38.10 | `^0.38.10` | | my-mini-zora | 0.38.8 | `^0.38.8` | | my-simple-mini-app | 0.38.10 | `^0.38.10` | | three-card-monte | 0.38.13 | `^0.38.13` | No lockfiles change: every pin is the version already resolved there. Upgrading these demos to OnchainKit 1.x is a separate piece of work with real API changes behind it; this only stops the unintended jump.
memosr
force-pushed
the
fix/onchainkit-pin-versions
branch
from
September 5, 2026 20:23
f0945e3 to
0b93491
Compare
memosr
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Four workshop demos declare
"@coinbase/onchainkit": "latest"while their committedpackage-lock.jsonis locked to a 0.38.x build.lateston npm is currently 1.1.2, a major version ahead, so a freshnpm installin any of them resolves the floating tag and pulls OnchainKit 1.x into a demo written and locked against the 0.38 API.Each manifest is pinned to a caret range matching the version already resolved in its own lockfile, so the two agree and installs stay reproducible.
Affected demos
mini-apps/workshops/mini-neynarlatest^0.38.10mini-apps/workshops/my-mini-zoralatest^0.38.8mini-apps/workshops/my-simple-mini-applatest^0.38.10mini-apps/workshops/three-card-montelatest^0.38.13No lockfile changes: every pin is the version already present there.
Rebased
This PR originally also touched
paymaster/hangman-onchainandpaymaster/onchain-game-lingos. Both demos were removed from the repo in #137, so the branch has been rebuilt on currentmasterand now covers only the four demos that still carry the floating tag.Not included
Upgrading these demos to OnchainKit 1.x is separate work with real API changes behind it. This only stops the unintended major-version jump.